Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Immediately return if any of the requests succeeds #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Immediately return if any of the requests succeeds #24

wants to merge 1 commit into from

Conversation

Daplex
Copy link

@Daplex Daplex commented Oct 6, 2021 •
edited
Loading

Fixes #23 (comment)

Breaking Changes:
I had to change the _lastTryResults variable, it now contains the result of the first successfully completed Future.

@Daplex Daplex mentioned this pull request Oct 6, 2021
Open
@AErmek
Copy link

AErmek commented Jan 14, 2022

@Daplex
If it possible that one of ip addresses will be unavailable and that request Future completed first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify testing logic to immediately return if any of the simultaneous pings succeed
2 participants
@Daplex @AErmek