This repository has been archived by the owner on Jan 9, 2025. It is now read-only.
refactor(ssj): move MockContractUpgradeable to separate file #1676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move MockContractUpgradeableV0 and MockContractUpgradeableV1 contracts to new file
File contents moved to mock_contract_upgradeable.cairo
|
Sorry for the late reply and lack of review. We've been pausing the development of I'm cognizant that you spent some time doing this PR, so thank you. I will have to close it since I am cleaning a bit the repo and preparing for archival. Archiving the repo will solve issue of people working on stuff while we are not accepting new PRs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time spent on this PR: 0.5 days
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Currently,
MockContractUpgradeableV1is located intest_upgradeable.cairofile, which is no longer needed as mentioned in issue #1559.Resolves #1559
What is the new behavior?
MockContractUpgradeableV0andMockContractUpgradeableV1contracts to a new filemock_contract_upgradeable.cairotest_upgradeable.cairoas it's no longer neededtest_kakarot_core.cairo