Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RMLTC0007x mixing data files and references #58

Open
arenas-guerrero-julian opened this issue Feb 3, 2022 · 0 comments
Open

RMLTC0007x mixing data files and references #58

arenas-guerrero-julian opened this issue Feb 3, 2022 · 0 comments

Comments

@arenas-guerrero-julian
Copy link

Hi there,

The original R2RMLTC0007x test cases use the same SQL table with two columns: ID and Name.

However RMLTC0007x test cases seem to use a table (in the case of CSV but the same happens for JSON & XML) with three columns: ID, FirstName, LastName. It seems to me like an error because (as far as I have seen):

  • LastName is not used in the mappings.
  • RMLTC0007e uses indeed a table with two columns: ID and Name. I assume this is wrong since RMLTC0007x should use the same data sources.
  • RMLTC0007h has a wrong reference in the mapping. Specifically the mapping uses the reference Name but it does not exist in the data file. This is wrong because testing a wrong reference is not the original purpose of this test case.

Julián
ghsnd pushed a commit to ghsnd/rml-test-cases that referenced this issue Nov 7, 2024
Fix RMLTC0007h
b90d505 
- Specify that it should throw an error (in metadata.csv).
- Use existing references in the mapping rules so that the real issue (generating a non-IRI graph) can be easily tested.
- Fixes kg-construct#38 kg-construct#58 kg-construct#13
@ghsnd ghsnd mentioned this issue Nov 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arenas-guerrero-julian