-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converters do not work with IOSvc
#202
Comments
This probably needs a bit more work, because currently the The k4MarlinWrapper/k4MarlinWrapper/src/components/LcioEventAlgo.cpp Lines 67 to 68 in 3165e40
Does this still work with the IOSvc ? @jmcarcell IIUC, this should still work, but the LCEvent will not be available for our functional algorithms, right?
For the converters it should be possible to put in place checks that check the |
As discussed during the EDM4hep meeting, we will not put too much effort into supporting If necessary we will come back to this in the future to add support. For now we will mainly try to avoid the segmentation fault and rather give users a proper error for that. |
Trying to raise the priority of this issue: it is not really a matter of running in multi-threaded way, it is rather that we try to write all the new algorithms with Functionals and this issue currently prevents one to access the ILCSoft world. |
I would also like to add in my voice, here. The fact that we can't use the converters with Transformers is hampering my progress on Muon Collider work. I've converted a number of Marlin Processors to Transformers but now I have to run the converted algorithms separately from the ones that are still in MarlinWrappers. |
Hi @samf25 , are these translated Marlin Processors available centrally in Key4hep? |
No. Currently, they are just located in a separate repo (there's also TrackPerf, and I am currently working on some digitization libraries). Once I can get it all hooked up and running (with MarlinWrappers around they as of yet untranslated ones) they will be added to the MuCol software stack. I don't think there are any plans to include them centrally since they are specific to the muon collider. |
The converters still partially refer to the
PodioDataSvc
explicitly and will fail with a segmentation violation when used with theIOSvc
.The text was updated successfully, but these errors were encountered: