Skip to content
This repository has been archived by the owner on Oct 17, 2023. It is now read-only.

Linked Collections are not converted #10

Closed
fdplacido opened this issue Apr 6, 2021 · 4 comments
Closed

Linked Collections are not converted #10

fdplacido opened this issue Apr 6, 2021 · 4 comments

Comments

@fdplacido
Copy link
Contributor

I created a test in k4MarlinWrapper to test conversion of collections from EDM4hep to LCIO to EDM4hep.
When converting Tracks, these can have other Tracks linked to it. I test that these linked Tracks remain in the conversion between EDM4hep to LCIO.
But when converting from LCIO to EDM4hep these linked Tracks are missing in the resulting EDM4hep collection. This is probably true for other collections that have linked collections.

The conversion is done using k4LCIOConverter like so:

podio::CollectionIDTable* id_table = new podio::CollectionIDTable();
k4LCIOConverter* lcio_converter = new k4LCIOConverter(id_table);
lcio_converter->set(the_event);

T* mycoll = dynamic_cast<T*>(lcio_converter->getCollection(lcio_name));
@zoujh
Copy link
Collaborator

zoujh commented Apr 6, 2021

Hi @fdplacido , is it possible to send me ([email protected]) such a data sample? It's important to reproduce the problem for debugging. Thanks!

@fdplacido
Copy link
Contributor Author

I sent you the data sample and some info. Thanks!

@zoujh
Copy link
Collaborator

zoujh commented Apr 9, 2021

If object A and B are in the same collection, then A cannot be linked to B correctly. This is fixed in this commit. Thank you!

@fdplacido
Copy link
Contributor Author

I tested this and it works fine now, thank!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants