Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen is still visible after disconnecting? #128

Open
LupoLucario opened this issue Apr 12, 2022 · 27 comments
Open

Screen is still visible after disconnecting? #128

LupoLucario opened this issue Apr 12, 2022 · 27 comments

Comments

@LupoLucario
Copy link

After closing the connection (via smartphone), youtube on the mirror is still visible and asks me, if I want to login or not.

Screen

A reconnection is possible and works. But I can not get rid of the window without restarting the mirror :/

@Jasa1983
Copy link

Hi have the same issue.

@bobsusedtires
Copy link

Same. Works on my other mirror though. I'm running out of ideas. Seems like if I could click continue as guest, it'd be fine, but I already hid my mouse. lol

@bobsusedtires
Copy link

It is ONLY the youtube app from my phone. Every other app from phone, or computer, or whatever works fine.

@vinaynaik121
Copy link

Having same issue anyone got solution for this??

@mugen2220
Copy link

Anyone find a fix?

@bobsusedtires
Copy link

I cloned the SD from my other mirror and tried it on new hardware. Still have the screen coming up on the new one, while my old mirror is fine. Has to be something silly.,..

@Davrent
Copy link

Davrent commented Jul 16, 2022

Bonjour, j'ai le même souci sur une nouvelle installation. Quelqu'un à trouvé une solution ? Merci :)

Hello, I have the same problem on a new installation. Has anyone found a solution? Thanks :)

@amithapa
Copy link

@LupoLucario Any luck with this issue?
@kevinatown any suggestion how we could get this working?

@LupoLucario
Copy link
Author

I tried several things: different devices, networks and circumstances but without any luck so far.

@kevinatown
Copy link
Owner

Hi y'all, sorry about the delay on this, been busy with work, house, life, and some other projects. Anyways..

Some more information would be greatly appreciated, such as:

  • @LupoLucario what version of MagicMirror are you using?
  • are you able to reconnect to your MagicMirror with you phone and then "Disconnect"?
  • Can you disconnect before the video ends? and does MMM-Screencast disappear?
  • Would it be possible to add some logs of you starting up the MM, running screen cast, and potentially disconnecting?

You can do the log like so: npm start >> log.log and stick that log in here? Thanks!

@LupoLucario
Copy link
Author

Hi kevin,

  • the MagicMirror version I use is 2.20.0
  • there is no difference when I reconnect after first disconnecting and try to disconnect again
  • also when I disconnect while the video is still playing it shows the screen I uploaded in the first post of the thread

Here is the log of starting the mirror, connecting with the phone (not playing any video), and disconnecting. For a better readability I disabled all of my other modules:

> [email protected] start
> DISPLAY="${DISPLAY:=:0}" ./node_modules/.bin/electron js/electron.js

[07.08.2022 16:34.20.222] [LOG]   Starting MagicMirror: v2.20.0
[07.08.2022 16:34.20.230] [LOG]   Loading config ...
[07.08.2022 16:34.20.237] [LOG]   Loading module helpers ...
[07.08.2022 16:34.20.392] [LOG]   Initializing new module helper ...
[07.08.2022 16:34.20.394] [LOG]   Module helper loaded: MMM-Screencast
[07.08.2022 16:34.20.395] [LOG]   All module helpers loaded.
[07.08.2022 16:34.20.523] [LOG]   Starting server on port 8086 ... 
[07.08.2022 16:34.20.536] [LOG]   Server started ...
[07.08.2022 16:34.20.538] [LOG]   Connecting socket for: MMM-Screencast
[07.08.2022 16:34.20.540] [LOG]   Sockets connected & modules started ...
[07.08.2022 16:34.20.846] [LOG]   Launching application.
[07.08.2022 16:34.36.195] [LOG]   screencast stdout: 
> [email protected] start
> electron app.js


[07.08.2022 16:34.38.080] [LOG]   screencast stderr: (node:18655) electron: The default of contextIsolation is deprecated and will be changing from false to true in a future release of Electron.  See https://github.com/electron/electron/issues/23506 for more information

Thank you for your help =)

@goldyfruit
Copy link
Contributor

I got the same behavior.

@Egnos87
Copy link

Egnos87 commented Sep 30, 2022

I have the same problem...please @kevinatown help us! Thanks

@mrwertman
Copy link

mrwertman commented Oct 10, 2022

This is happening for me also. @kevinatown

@bobsusedtires
Copy link

Started happening on my other install that was working before.

goldyfruit added a commit to smartgic/MMM-Screencast that referenced this issue Oct 10, 2022
This fix is inspired by https://github.com/amirthapa27/MMM-Screencast

When autoCloseScript is called, it sends a message (mmm-screencast.exited)
to the console. If the message is received then an IPC is emitted as
well as a call to the app.quit() method.
@Dresch360
Copy link

Having the same issue - is there a fix?

@goldyfruit
Copy link
Contributor

goldyfruit commented Oct 14, 2022

I did a PR here: #132
Waiting for @kevinatown to look at it.

@Egnos87
Copy link

Egnos87 commented Oct 14, 2022

I did a PR here: #128 Waiting for @kevinatown to look at it.

Does this fork https://github.com/amirthapa27/MMM-Screencast solve the problem?

Thanks

@goldyfruit
Copy link
Contributor

goldyfruit commented Oct 15, 2022

I did a PR here: #128 Waiting for @kevinatown to look at it.

Does this fork https://github.com/amirthapa27/MMM-Screencast solve the problem?

Thanks

Yes but it opens the developer tools.

You can use https://github.com/smartgic/MMM-Screencast with the fix_window_still_visible branch.

@Egnos87
Copy link

Egnos87 commented Oct 16, 2022

I did a PR here: #128 Waiting for @kevinatown to look at it.

Does this fork https://github.com/amirthapa27/MMM-Screencast solve the problem?
Thanks

Yes but it opens the developer tools.

You can use https://github.com/smartgic/MMM-Screencast with the fix_window_still_visible branch.

Ok, thanks.
The other big problem (perhaps worse than the issue #128 ...) is the one described in this issue #131 , that is the impossibility to connect.

Is there a solutions?

@SyedIntekhab
Copy link

The connecting issue fixes itself when you do npm audit fix - - force.

But the window still visible problem creeps back in. :(

@Tom-Hirschberger
Copy link

I tried the fix of @goldyfruit with Raspberry OS Buster and Bullseye. In my case it works with both os versions

@marsul23
Copy link

I am having the same issue. After closing the connection (via smartphone), youtube on the mirror.
fix_window_still_visible branch does not solve the problem. Any ideas?

@devtobi
Copy link

devtobi commented Sep 13, 2023

For me, the fork of @goldyfruit fixed the error of closing the module. However, I still have connection issues after connecting to the mirror once. Only a restart of MM2 fixes the error, which means I have to restart the mirror after each screencast, which kind of sucks.

@Goggite
Copy link

Goggite commented Dec 14, 2023

Hello!
Will here be update which hide module after translation ending?

@Skyview79
Copy link

I've used the branch: fix_window_still_visible but it doesn't help my situation.
The Youtube window remains open after I close the player on the phone.

Raspberry Pi 4, x64 6.1.21-v8+
MagicMirror 2.26.0

kevinatown added a commit that referenced this issue Sep 11, 2024
* Fix issue #128

This fix is inspired by https://github.com/amirthapa27/MMM-Screencast

When autoCloseScript is called, it sends a message (mmm-screencast.exited)
to the console. If the message is received then an IPC is emitted as
well as a call to the app.quit() method.

* Update app.js

Co-authored-by: Kevin Townsend <[email protected]>

---------

Co-authored-by: Kevin Townsend <[email protected]>
@dennisklad
Copy link

Hi, I just pulled the new code and I have the same issue after a fresh installation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests