Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: workflow-benchmarking #2980

Closed
wants to merge 10 commits into from
Closed

feat: workflow-benchmarking #2980

wants to merge 10 commits into from

Conversation

Matvey-Kuk
Copy link
Contributor

@Matvey-Kuk Matvey-Kuk commented Jan 5, 2025 •
edited
Loading

None

Closes #2991

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 5, 2025
@vercel Vercel
Copy link

vercel bot commented Jan 5, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 2:37pm

@Matvey-Kuk Matvey-Kuk marked this pull request as draft January 5, 2025 17:53
@dosubot dosubot bot added the Feature A new feature label Jan 5, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 5, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 9.67742% with 28 lines in your changes missing coverage. Please review.

Project coverage is 43.40%. Comparing base (3e3a0e6) to head (ddea90a).
Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
keep/api/routes/workflows.py 9.67% 28 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2980      +/-   ##
==========================================
- Coverage   43.52%   43.40%   -0.12%     
==========================================
  Files         165      165              
  Lines       16250    16335      +85     
==========================================
+ Hits         7073     7091      +18     
- Misses       9177     9244      +67

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Matvey-Kuk Matvey-Kuk marked this pull request as ready for review January 6, 2025 17:46
@dosubot dosubot bot added the API API related issues label Jan 6, 2025
@Matvey-Kuk Matvey-Kuk mentioned this pull request Jan 6, 2025
Open
VladimirFilonov
VladimirFilonov previously approved these changes Jan 6, 2025
View reviewed changes
@talboren
Copy link
Member

Closing for now (leaving branch as-is) until we decide if that's a proper way to benchmark workflows.

@talboren talboren closed this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirFilonov VladimirFilonov VladimirFilonov approved these changes

Assignees
No one assigned
Labels
API API related issues Feature A new feature size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[👨🏻‍💻 Internal]: workflow-benchmarking
3 participants
@Matvey-Kuk @talboren @VladimirFilonov