-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[➕ Feature]: Improve workflow validation #1885
Comments
@shahargl I would like to work on this. can you please guide me on what are the improvements we need? |
@rajeshj11 yes! updated ticket. |
@shahargl Can we create two identical workflows? |
/bounty 50 |
💎 $50 bounty • Keep (YC W23)Steps to solve:
Thank you for contributing to keephq/keep! Add a bounty • Share on socials
|
/attempt #1885
|
@Matvey-Kuk is anyone working on this currently? I would like to attempt it. |
@35C4n0r it's yours! |
/attempt #1885
|
@35C4n0r I have already attempted the issue, and although I wasn't able to get my changes merged, I do have some context on the modifications. If needed any assistance on this feature. feel free to reach out to me. I am open to collaborate |
Can you please give this PR a better indicative name? 🙏🏼 |
Payout for this bounty will be executed via GitHub Sponsors, not via Algora. Please activate https://github.com/sponsors/accounts for your account to receive the payout, sorry for the inconvenience |
Related to keephq#1885 Update workflow parsing to use `id` as id and `name` as name, generate different UUID if `id` is not provided, and add validation for configuration errors. * **keep/parser/parser.py** - Update `_get_workflow_id` to use `workflow.get("id")` for id and `workflow.get("name")` for name. - Add logic to generate a different UUID if `workflow.get("id")` is not provided. - Update `_parse_workflow` to use `workflow.get("name")` for name. * **keep/api/models/db/workflow.py** - Add a new field `invalid` to mark workflows with configuration errors. - Update the `Workflow` class to include the `invalid` field. * **keep/api/routes/workflows.py** - Update `create_workflow` and `create_workflow_from_body` to generate a different UUID if `workflow.get("id")` is not provided. - Add validation logic to mark workflows with configuration errors as `invalid`. * **tests/test_parser.py** - Add test cases to verify that a different UUID is generated if `workflow.get("id")` is not provided. - Add test cases to verify that workflows with configuration errors are marked as `invalid`.
The text was updated successfully, but these errors were encountered: