-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Way to save bookmark via Javascript bookmark #51
Comments
For Firefox & Chromium there are AddOns available |
Hi, anyone working on this or/and has any suggestions? For me working with the existing FF/Chrome-Extension works fine on any Desktop (Linux,Mac,Windows). On iOS i use a dirty Pythonista-Script to call via iOS-Apps 'share with...'-menu - but on Android mobiles i am stuck at the moment. :-/ It would be great if a more generic solution could be implemented directly into Reminiscence. What are you guys thinking about implementing it as a Bookmarklet? IMHO asking the user for giving his/her user-credentials somewhere else than on the (trusted) login-page of the app (for making the requests to get the AuthToken) is not rly user-friendly. So i am thinking about allowing (Browser-)Session-based Auth beside the Token-based one. That's for example how Twitter allows sending Tweets. Very easy to use and transparent for users - the user just needs to authenticate via Browser to the frontend (Session) and to call the Bookmarklet (which posts the url to the Application via HTTP-GET). Wrote a quick patch (f6a4ad1) to try this out:
Your suggestions in refining this would be cool. Same if someone is already working on a even simpler solution and whants to discuss / share it of course. Thx! Greetings, |
Hi,
Yeah.. to be honest.. I'm also not fan of sending username/password via browser extensions. So, I think token based auth is still better.. What I was thinking of earlier is, giving a way to generate tokens via Reminiscence frontend for a fixed expiry time, I'm open to suggestions though, for any flexible, convenient and secure auth based system for developing extensions.
that's cool. If possible can you share link to the snippet/instructions? I'll add it to the browser addons wiki, in case anyone needs it.
I'm also not good with android development.. So I'm also not sure how to solve the issue here.. Anyway thanks for starting inititive Sven. I'll also try to look into the issue whenever possible. |
kanishka-linux#51; adds demo-bookmarklet
Hi, thanks for your reply. Just to clarify in case there is a misunderstanding about the bookmarklet approach i had in mind -
No need to do any complicated javascript-foo to interfere with the Session here (see above demo-code) -
Any Browser-Extensions & hacks (like mine for iOS) for browsers which supports bookmarklets would be obsolete if we implemet it as a Bookmarklet using Session-Auth i hope (at least that's the idea - i may be terribly wrong, wouldn't be the first time ;). Anyways: producing valid Tokens with expiry time over the frontend would be great in lotso cases imho - i personally don't feel so good to have to use user-credentials in scripts which are calling the API too. The UX i thought of (and updated the patch accordingly) is: when the bookmarklet is called (a one-cklick operation) it opens a new tab where the currently visited page is transmitted to the API (or prepopulate a add-url-view).
example-results (success): Of course this is only my oppinion / suggestion. Not grumpy if you disagree :)
Cool! Looking forward to a solution which makes it into vanilla.
Of course. I'll put in on github the next days if you/anybody is interested.
Thank you for your awesome work. I use Reminiscence nearly every day since months and are very happy with it! :) |
I think, I don't know much about bookmarklet and I think I still have some confusion around DRF's session based auth.
It is really great to read that you are using it regularly, awesome :) |
FYIO : put the iOS/Pythonista-Hook here https://github.com/s3h10r/sharewith-iOS |
Hi, i started a version of the bookmarklet-idea which doesn't require the discussed API change here. It's just a Django-App which can be plugged into reminiscence without needing to patch it. I thought that's maybe better than code-changes? it provides 3 simple new views:
source: https://github.com/s3h10r/reminiscence-bookmarklet Greetings, |
Hi, For bookmarklet-idea, there are couple of issues
Anyway, Thanks for iOS/Pythonista-Hook.., updated the wiki. :) |
Hi, okidoki, thanks for thinking about it! :) Looking forward what solution makes it into vanilla. |
Bookmarking should be a quick and easy task.
To have to navigate to Reminiscence and paste in the URL is a lot of labor, especially on mobile.
Is there a solution in place for this that I did not see, or is this something that could be added at some point?
The text was updated successfully, but these errors were encountered: