Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the project PEP-518 compliant #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make the project PEP-518 compliant #8

wants to merge 2 commits into from

Conversation

mrapplexz
Copy link

Hello! These changes make the fastwer package compatible with PEP-518 and remove unneeded runtime dependency on pybind11.
Should fix #2 and #5 . Also, the package now installs without any problems using Poetry and other PEP-518 compliant build systems and package managers.
https://pybind11.readthedocs.io/en/stable/compiling.html#pep-518-requirements-pip-10-required

@ichko
Copy link

ichko commented Feb 24, 2023

Can we have these changes merged?

@DominikAgejev DominikAgejev mentioned this pull request May 1, 2024
Open
@gregbugaj
Copy link

To install / compile this with G++ 13 you will need to modify two files:

pip install -e .

Here is a git diff that you can apply


diff --git a/src/fastwer.hpp b/src/fastwer.hpp
index abcdefg..hijklmn 100644
--- a/src/fastwer.hpp
+++ b/src/fastwer.hpp
@@ -1,6 +1,7 @@
 #ifndef FASTWER_FASTWER_HPP
 #define FASTWER_FASTWER_HPP
 
+#include <cstdint>
 #include <vector>
 #include <string>
 #include <sstream>
diff --git a/src/fastwer.cpp b/src/fastwer.cpp
index opqrstu..vwxyzab 100644
--- a/src/fastwer.cpp
+++ b/src/fastwer.cpp
@@ -1,5 +1,6 @@
 #include "fastwer.hpp"
 #include <cmath>
+#include <cstdint>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pybind11 requirement
3 participants
@mrapplexz @ichko @gregbugaj