Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update matplotlib Requirement #267

Open
QuentinFuxa opened this issue Jan 19, 2025 · 0 comments
Open

Update matplotlib Requirement #267

QuentinFuxa opened this issue Jan 19, 2025 · 0 comments

Comments

@QuentinFuxa
Copy link

The current matplotlib version requirement in diart (matplotlib>=3.3.3,<3.6.0) is outdated and causes installation failures with Python 3.13 due to issues with building the matplotlib wheel: ERROR: Failed building wheel for matplotlib

Proposed Update:
I suggest raising the matplotlib version requirement to include more recent versions. I have tested the main functionalities of diart with the latest version of matplotlib, and they work correctly. You can see my implementation here: whisper_streaming_web.

Testing Notes:
While the main functionalities seem to work with the updated version, I have not tested the figure generation code at line 122 in dsrc/diart/sinks.py.

And thank you for maintaining this great project!

Quentin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant