Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reasampling - suggested improvement #10

Open
alangi opened this issue Dec 22, 2023 · 2 comments
Open

Reasampling - suggested improvement #10

alangi opened this issue Dec 22, 2023 · 2 comments

Comments

@alangi
Copy link

alangi commented Dec 22, 2023

Hi,

Currently the pmin and pmax values are set manually and throw value errors if they are above the range of the data. This could be refactored to automatically set the values to the maximum and minimum possible if an error is encountered.

@jpvantassel
Copy link
Owner

Hi @alangi,
This should be easy to add. Thanks!
Joe

@jpvantassel
Copy link
Owner

Hi @alangi,

I just changed resampling to only returns interpolated values with this commit. You can define the data to be resampled over any range to get any frequency or wavelength sampling you would like but now only the interpolated values are returned (extrapolated values are screened out).
Thanks,
Joe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants