Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set vjust in easy_rotate_x_labels()? #53

Open
krlmlr opened this issue Jul 5, 2020 · 2 comments
Open

Set vjust in easy_rotate_x_labels()? #53

krlmlr opened this issue Jul 5, 2020 · 2 comments
Milestone

Comments

@krlmlr
Copy link

krlmlr commented Jul 5, 2020

The default vjust looks a bit awkward to me. I know I can set with #18, what's a good default?

library(tidyverse)

data <- tibble(a = 1:3)
data %>%
  ggplot(aes(a, a)) +
  geom_point() +
  ggeasy::easy_rotate_x_labels()

data %>%
  ggplot(aes(a, a)) +
  geom_point() +
  theme(axis.text.x = element_text(angle = 90, hjust = 1, vjust = 0.5))

Created on 2020-07-05 by the reprex package (v0.3.0)

@jonocarroll
Copy link
Owner

I agree - centering looks good.

@jonocarroll jonocarroll added this to the 0.1.3 milestone Jul 6, 2020
@yonicd
Copy link
Collaborator

yonicd commented Jul 6, 2020

As a default 0.5 makes sense, but vjust can be tricky on axis rotation when the tick text is wrapped. In such cases 0.5 doesn’t work well from past experience.

Related feature could be to justify text after rotation. When you have longer labels it looks weird since they are staggered due to the default justification to the left (down) if I remember correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants