Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Absorb flush_ticks() #15

Open
jonocarroll opened this issue Nov 16, 2017 · 6 comments
Open

Absorb flush_ticks() #15

jonocarroll opened this issue Nov 16, 2017 · 6 comments

Comments

@jonocarroll
Copy link
Owner

As per blog post, @hrbrmstr has a new function in hrbrthemes which looks like it could also have a home here.

https://github.com/hrbrmstr/hrbrthemes/blob/master/R/flush-ticks.R

though it takes a different approach to adding the theme( part.

I'll see if I can bring him into the discussion here.

@hrbrmstr
Copy link
Contributor

who? wha?

:-)

how may I be of service?

@jonocarroll
Copy link
Owner Author

Have a peek at the vignette if you're interested; we're working on a bunch of shortcuts to theme( calls and flush_ticks() looks like it would fit in nicely. We also generate the call the "hard way" and print to console if someone wants to learn how to do it themselves (teach = TRUE).

Thoughts on either migrating it, us copying it, us wrapping it, or vice-versa?

@hrbrmstr
Copy link
Contributor

This is absolutely a better home for it. I added "the hard way" earlier today :-) Said way also copies the taught code to the clipboard to avoid the need for folks to copy/paste.

I can def migrate it over.

@jonocarroll
Copy link
Owner Author

If you're interested in adding more then feel free to PR something in keeping with what we have, otherwise I'm sure one of us will be happy to do so. I've no doubt you have some great ideas about which calls could be made easier (read: which things you wish you could do easier).

@jonocarroll
Copy link
Owner Author

We're also spitballing ideas in issues if you have something that could be included. The entry restriction is that the "hard way" needs to be easy enough to write down in about a line; no large-scale new transformations or things that would be difficult to add in any other way.

@hrbrmstr
Copy link
Contributor

tossed in an initial PR (with a TODO so keep this issue open pls :-)

I've def got some things that I do gg-wise that I'm finally deciding to "automate" / "ease-ify" and this wld be a great place for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants