From 416fb3fdac1f955cd8f0077999ddc38cda488175 Mon Sep 17 00:00:00 2001 From: "joe.miyamoto" Date: Tue, 9 Jun 2020 15:26:32 +0900 Subject: [PATCH] Skip macaroon tests which uses third party caveats. * Since Third party caveats are only supported through DotNetLightning.Core. This is because third-party caveats uses cryptographic operation. and we want to change the actual implementation in DotNetLightning.Core --- tests/Macaroons.Tests/SerializationTests.cs | 2 +- tests/Macaroons.Tests/VerificationTests.cs | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/Macaroons.Tests/SerializationTests.cs b/tests/Macaroons.Tests/SerializationTests.cs index b39465ce8..1dc724670 100644 --- a/tests/Macaroons.Tests/SerializationTests.cs +++ b/tests/Macaroons.Tests/SerializationTests.cs @@ -69,7 +69,7 @@ public void CanDeserializeMultipleFirstPartyCaveats() } - [Fact] + [Fact(Skip = "Skip third party caveat tests")] public void CanSerializeAndDeserializeThirdPartyCaveats() { // Arrange diff --git a/tests/Macaroons.Tests/VerificationTests.cs b/tests/Macaroons.Tests/VerificationTests.cs index 30a351cd2..1005cc82e 100644 --- a/tests/Macaroons.Tests/VerificationTests.cs +++ b/tests/Macaroons.Tests/VerificationTests.cs @@ -160,7 +160,7 @@ public void VerificationFailsWithInvalidSignature() } - [Fact] + [Fact(Skip = "Skip third party caveat tests")] public void CanVerifyWithMultipleDischargeMacaroons() { // Arrange @@ -201,7 +201,7 @@ public void CanVerifyWithMultipleDischargeMacaroons() } - [Fact] + [Fact(Skip = "Skip third party caveat tests")] public void VerificationFailsWhenDischargeMacaroonIsMissing() { // Arrange @@ -244,7 +244,7 @@ public void VerificationFailsWhenDischargeMacaroonIsMissing() } - [Fact] + [Fact(Skip = "Skip third party caveat tests")] public void VerificationFailsWhenPredicatesForThirdPartyCaveatIsMissing() { // Arrange @@ -285,7 +285,7 @@ public void VerificationFailsWhenPredicatesForThirdPartyCaveatIsMissing() } - [Fact] + [Fact(Skip = "Skip third party caveat tests")] public void VerificationFailsWhenHavingCircularMacaroonReferences() { // Arrange