-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom accent color #225
Comments
As I've stated before, I am not going to provide alternative color variants for the theme. Everyone has their own preference, and those should belong in separate forks. The highlight colors are indeed easy to change with Othewise the Since there's nothing to do here I'm gonna close this, but feel free to add more comments if there's anything else. |
Indeed, that's why in my opinion it is a good idea to provide some basic color alternatives, many themes do that. You (and horst3180) have done such a great job with this theme that I find it to be really a shame that it is not more accessible to more people. Some people like me don't like blue and they will therefore not use that theme and go to some other shitty theme to realize 8 months later after they run the last update of their favorite program that GTK4 is not properly supported. My point is that not everyone has the technical knowledge to be able to:
Providing alternative colors without changing much of the overall look and feel is a great way to allow less tech savy people to use this great theme, specially considering it's not a lot of work to run some sed commands in a GitHub CI. It could also be explicitly stated that "these themes have not been thoroughly tested, you should use the blue color" But hey it's your project now, you do whatever you want !
I did not have to do that, it was really as simple as running some Maybe that's because I only tested the GTK theme. Though it seems that color hue is already calculated by the scss files themselves based on the
|
A note for future googlers ending up here: I ended up creating my own fork of jnsh's repo, which generates various color palettes of this theme (see the readme for a showcase of available palettes). I'm no maintainer of this theme (jnsh is) and will not add any feature or bug fixes (except the ones related to my changes). All the variants are pre-built for you and published as release artifacts, it's only a matter of downloading the archive for the color you want and extracting it in your themes folder. For now only the following colors are generated:
Let me know if you want any another color, it's just a matter of adding 1 line to a config file. |
Hi, sorry to hijack your issue tracker for something that is not an issue. I have a suggestion that could potentially easily allow color variations of this very nice theme. And if you don't want to do what I suggest (which is perfectly fine), I figured this issue could help others to try to do it themselves.
First I should say that I only tried this with GTK themes (my guess is that it would also mostly work for the others).
I managed to change the accent color by changing only 3 colors in the source files:
$selected_bg_color
fromcommon/gtk-3.0/sass/_colors.scss
$suggested_color
fromcommon/gtk-3.0/sass/_colors.scss
common/gtk-3.0/assets/assets.svg
Most of the SCSS code uses
darken()
andlighten()
, therefore I don't believe there are that many color codes to change in all the themes to be able to have color variants of the Arc theme.Here's what
gtk3-widget-factory
looks like by changing these 3 files:Everything looks perfectly fine, even Firefox I'm writing this issue with is colored properly (the blue color we see on the image is a color picker, I don't think it's related to the blue color of Arc).
From what I gathered, there are only two colors that are really specific to Arc and that affect most of the colors we see in our applications:
#5294e2
and#4dadd4
.So basically here are the only two commands you need to be able to change the blue accent color of Arc:
For me, I replaced both with
#b71c1c
:)I guess this process could be automated as part of a GitHub CI that would automatically release a tarball per color (I can help with that if you want me to).
Whether you decide to do something about it or not, thanks a lot for your work !
The text was updated successfully, but these errors were encountered: