Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brighten differs from pre v1 #1371

Open
Steve-Mcl opened this issue Dec 31, 2024 · 0 comments
Open

brighten differs from pre v1 #1371

Steve-Mcl opened this issue Dec 31, 2024 · 0 comments

Comments

@Steve-Mcl
Copy link

Has the parameter value definition changed from Jimp 0.x to 1.x?

Expected Behavior

Brightness with a value of 0 should not affect image like it did in v0.x
Brightness with a value of 1 should fully lighten an image like it did in v0.x
Brightness with a value of -1 should fully darken an image like it did in v0.x
Brightness with a value of -0.5 should half darken an image like it did in v0.x
Brightness with a value of 0.5 should half lighten an image like it did in v0.x

Using Jimp V0.x (using Node-RED to simplify testing)
image

Current Behavior

Brightness with a value of 0 in v1.6 behaves differently - it darkens the image
Brightness with a value of 1 in v1.6 behaves differently - it has little affect on the image
Brightness with a value of -1 correctly fully darkens an image like it did in v0.x
Brightness with a value of -0.5 in v1.6 behaves differently - it FULLY darkens the image
Brightness with a value of 0.5 in v1.6 behaves differently - it half darkens the image

image

Failure Information (for bugs)

Steps to Reproduce

Demonstrating -0.5 brightness

  1. load image
    1. image
  2. invert
    1. image2
  3. apply brightness -0.5
    1. image3

Demonstrating -0.0 brightness

  1. load image
    1. image
  2. invert
    1. image2
  3. apply brightness -0.0
    1. image3

Demonstrating 1.0 brightness

  1. load image
    1. image
  2. invert
    1. image2
  3. apply brightness 1.0
    1. image3

Context

  • Jimp Version: 1.6.0
  • Operating System: Win 11
  • Node version: 18

Failure Logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant