Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove plot_subgraph #445

Open
jeromekelleher opened this issue Dec 13, 2024 · 2 comments
Open

Remove plot_subgraph #445

jeromekelleher opened this issue Dec 13, 2024 · 2 comments

Comments

@jeromekelleher
Copy link
Owner

I think we should remove the plot_subgraph method from this repo as it's generally been replaced with the ARG-visualiser and it'll be work to test and maintain. We can either move it to the paper repo (if we're going to use it there) or just delete, I don't really mind.

@hyanwong, what's your preference here?

@hyanwong
Copy link
Contributor

We should definitely remove it from this repo. There are two reasons we might want to keep it in the paper repo:

  1. For the paper, we might want a way to make plots that aren't just screenshots of the tskit_arg_visualizer output. I could imagine removing the graph-node placement code from the current plot_subgraph method, and getting that from the ARG visualizer though
  2. currently the tskit_arg_visualizer doesn't quite do what we want, which is to be able to selectively expand nodes on the route up or down from the focal node of interest. However, the best route here would be to expand the capabilities of the tskit_arg_visualizer instead, I think (I will open an issue)

For the moment, I think we can move the method wholesale into the paper repo, then tweak to fit the tskit_arg_visualizer output.

@jeromekelleher
Copy link
Owner Author

SGTM. Would you like to copy it over into the right place? I can take care of deleting things here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants