Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear add command requirements #9

Open
jeremiahlzz opened this issue Apr 19, 2024 · 1 comment
Open

Unclear add command requirements #9

jeremiahlzz opened this issue Apr 19, 2024 · 1 comment

Comments

@jeremiahlzz
Copy link
Owner

jeremiahlzz commented Apr 19, 2024

According to the add command format, address is optional

image.png

However it is stated that the professor role requires the address attached

This should have been mentioned within the add and edit command as it is crucial information.
It also invalidates the command formats as those arguments are no longer optional, they are mandatory.
Adding professors would be a very common thing to do and hence would inconvenience many users.
image.png

@nus-pe-script
Copy link

nus-pe-script commented Apr 22, 2024

Team's Response

image.png
It is mentioned within the edit command.

image.png
Also, if user forgot to have address field for professor, the error message would show it is needed. Thus, I think it is serverity low, but still needs to be mentioned in "add" command section in UG.

Items for the Tester to Verify

❓ Issue severity

Team chose [severity.Low]
Originally [severity.Medium]

  • I disagree

Reason for disagreement: I would also like to add that it is also a feature flaw. Since this is an app targeted at students, they would most likely be unaware of the professor's address (its creepy if they do, outside of extenuating circumstances). Having to always input a/none is annoying to all users, hence the medium severity.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants