Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appending f/ does not ignore the warning. #3

Open
jeremiahlzz opened this issue Apr 19, 2024 · 1 comment
Open

Appending f/ does not ignore the warning. #3

jeremiahlzz opened this issue Apr 19, 2024 · 1 comment

Comments

@jeremiahlzz
Copy link
Owner

jeremiahlzz commented Apr 19, 2024

Appending f/ directly does not clear warnings as documented in the error message.

image.png
Adding a space before /f is required.

@nus-se-bot
Copy link

nus-se-bot commented Apr 22, 2024

Team's Response

UG states the f/ prefix to have a space:
image.png

I believe that it should be naturally understood that f/ should be treated as any other prefix and have a space before them. Similarly, the normal/universal definition of append isn't a strict adding to the end without any space, but a general statement of attaching the prefix to the end (see below image example).

image.png

That having said, the error message has rooms for improvement: append " f/" to ignore the warning or add the f/ flag to ignore the warning (in the latter case the user would lookup the user guide to see how the flag is used). So valid feature request.

Items for the Tester to Verify

❓ Issue response

Team chose [response.NotInScope]

  • I disagree

Reason for disagreement: As said by the team, an easy fix is changing the error message to add prefix f/ to ignore the warning or add the f/ flag to ignore the warning.

Easily done and is important to users when they encounter an error and could potentially cause frustration.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants