Skip to content
This repository has been archived by the owner on Nov 29, 2018. It is now read-only.

Back button breaks when tokens start with / #6

Open
rdwallis opened this issue Dec 21, 2013 · 0 comments
Open

Back button breaks when tokens start with / #6

rdwallis opened this issue Dec 21, 2013 · 0 comments

Comments

@rdwallis
Copy link
Contributor

Demo code: https://github.com/rdwallis/pushstateslash

Live site: http://pushstateslash.appspot.com/

I know support was improved for tokens that start with '/' in 1.1-SNAPSHOT. I am using the latest version.

The back & forward button doesn't work after clicking a couple of links.

After looking through the gwt-pushstate code I think this may be too complex for a simple fix and recommend simply not supporting tokens that start with "/". Perhaps adding some asserts to enforce this.

To help I'll be uploading a version of RouteTokenFormatter later today that isn't required to begin with a slash (this will also fix ArcBees/GWTP#233) and a PushRouteTokenFormatter that explicitly requires that tokens don't start with a slash.

@jbarop jbarop added this to the gwt-pushstate-1.1 milestone Oct 7, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants