You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
Once you deserialize a serialized
BloomFilter
object theself.bitarray
length might differ because of added padding.https://github.com/jaybaird/python-bloomfilter/blob/master/pybloom/pybloom.py#L271
Here difference in length due to the trailing bits is ignored.
No such accounting of differing bitarray lengths are being done here https://github.com/jaybaird/python-bloomfilter/blob/master/pybloom/pybloom.py#L224 or https://github.com/jaybaird/python-bloomfilter/blob/master/pybloom/pybloom.py#L238 . Here the
bitarray
union and intersection will fail if the bitarray.length( ) are different. The lengths may differ because of a roundtrip through serialization deserialization, even when the capacity and error-rates are the same.I think the correct thing to do here is to strip off the padding in
fromfile
to ensure that thebitarray
representation is exactly the sameThe text was updated successfully, but these errors were encountered: