Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server-side language files #206

Open
iliakan opened this issue Sep 1, 2021 · 19 comments
Open

Server-side language files #206

iliakan opened this issue Sep 1, 2021 · 19 comments

Comments

@iliakan
Copy link
Member

iliakan commented Sep 1, 2021

Please translate the website UI files.
Keep the file structure "as is".

locales.zip

@iliakan
Copy link
Member Author

iliakan commented Sep 1, 2021

Translate to the right side of :.

@juuni26
Copy link
Member

juuni26 commented Sep 1, 2021

doing the work.

@juuni26
Copy link
Member

juuni26 commented Sep 1, 2021

@iliakan done.

here check it out!
locales.zip

@iliakan
Copy link
Member Author

iliakan commented Sep 1, 2021

Please review. Not all phrases are translated from English.

@juuni26
Copy link
Member

juuni26 commented Sep 1, 2021

Please review. Not all phrases are translated from English.

check this is my final translation. some phrases are best to leave in the original form to avoid ambiguity.
other maintainers can help to review the file. maybe bro @yoga1234 or others feel free.

locales.zip

@iliakan
Copy link
Member Author

iliakan commented Sep 1, 2021

Tried to import and run, failed for now.

There's a duplicate:

/opt/server/repo/id.javascript.info master
❯ find . -name *url
./5-network/06-url
./5-network/07-url

Please see which one is correct and keep it, remove the other one.

Also you might want to run https://github.com/javascript-tutorial/server and import the tutorial there, to see how it looks =)

@juuni26
Copy link
Member

juuni26 commented Sep 1, 2021

Tried to import and run, failed for now.

There's a duplicate:

/opt/server/repo/id.javascript.info master
❯ find . -name *url
./5-network/06-url
./5-network/07-url

Please see which one is correct and keep it, remove the other one.

Also you might want to run https://github.com/javascript-tutorial/server and import the tutorial there, to see how it looks =)

oof, gonna fix it soon :D

@juuni26
Copy link
Member

juuni26 commented Sep 1, 2021

Tried to import and run, failed for now.

There's a duplicate:

/opt/server/repo/id.javascript.info master
❯ find . -name *url
./5-network/06-url
./5-network/07-url

Please see which one is correct and keep it, remove the other one.

Also you might want to run https://github.com/javascript-tutorial/server and import the tutorial there, to see how it looks =)

done, please update the repo again.

@iliakan
Copy link
Member Author

iliakan commented Sep 1, 2021

image

@iliakan
Copy link
Member Author

iliakan commented Sep 1, 2021

Title missed? Malformatted?

@juuni26
Copy link
Member

juuni26 commented Sep 1, 2021

Title missed? Malformatted?

just check the whole repo, too much conflict I don't know. it will take time to fix.

@juuni26
Copy link
Member

juuni26 commented Sep 1, 2021

@iliakan u can try again, I think it's because the conflict is not resolved properly or repo just randomly merged whenever the update comes, so sometimes I found like "<<<< head in the file ", and there is much like that. and i need to fix it manually smh.

@iliakan
Copy link
Member Author

iliakan commented Sep 1, 2021

Please take a look at https://id.javascript.info/

Site search isn't working yet.
Tutorial repo updates are expected to appear on the website automatically.

@juuni26
Copy link
Member

juuni26 commented Sep 2, 2021

Please take a look at https://id.javascript.info/

Site search isn't working yet.
Tutorial repo updates are expected to appear on the website automatically.

well appreciated <3 , but there is a typo in the chooser of the language.
image

it appears Italiano not Indonesia, and also why the translated version feels zoomed out comparing the English version?

@iliakan
Copy link
Member Author

iliakan commented Sep 2, 2021

Ouch, I copied some config fields from Italian, fixed now.

There should be no additional zoom. No config options for that =)

@juuni26
Copy link
Member

juuni26 commented Sep 2, 2021

Ouch, I copied some config fields from Italian, fixed now.

There should be no additional zoom. No config options for that =)

hey, buddy is there a repo where I can submit a pull request to update the locales file? I think i need to update some of words after looking the site.

@iliakan
Copy link
Member Author

iliakan commented Sep 2, 2021

It's mostly at https://github.com/javascript-tutorial/server and https://github.com/javascript-tutorial/engine =)

You can update and zip → put here, I'll replace and redeploy.

@juuni26
Copy link
Member

juuni26 commented Sep 2, 2021

it's

It's mostly at https://github.com/javascript-tutorial/server and https://github.com/javascript-tutorial/engine =)

You can update and zip → put here, I'll replace and redeploy.

it's a minor update, but okay ill put it here.

locales.zip

@iliakan
Copy link
Member Author

iliakan commented Sep 2, 2021

modern_javascript_tutorial: Tutorial JavaScript Modern". -- please remove the quote (done that myself)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants