Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagram in DG does not follow what was taught in the course #6

Open
iynixil opened this issue Apr 19, 2024 · 1 comment
Open

Diagram in DG does not follow what was taught in the course #6

iynixil opened this issue Apr 19, 2024 · 1 comment

Comments

@iynixil
Copy link
Owner

iynixil commented Apr 19, 2024

Description of problem:
There are symbols/conventions used in the class diagram for the Find customer or order feature section of the Developer Guide.

Screenshot (if any):
image.png

Rationale:
VeryLow as this could be considered a cosmetic flaw since the explanation given under the diagram helps to explain. However, looking at the diagram itself, may not be readily understood what some things mean e.g A, C symbols used for the classes. This is assuming that readers are people who only know UML diagrams taught in CS2103/T.

Recommendation:
Use PlantUML to adhere to CS2103/T standards.

@nus-pe-bot
Copy link

nus-pe-bot commented Apr 22, 2024

Team's Response

This is in fact the class diagram from PlantUML as per the recommendation.

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: I understand that the class diagram was made in PlantUML, however the bug lies with deviating from CS2103/T standards for UML notations, and in this case, the "A", "C" symbols were not used in the course for class diagrams.

This was raised one of the exercises in Tutorial 10, as seen in the image below:
image.png


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants