Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI does not show immediately show the order created #3

Open
iynixil opened this issue Apr 19, 2024 · 1 comment
Open

GUI does not show immediately show the order created #3

iynixil opened this issue Apr 19, 2024 · 1 comment

Comments

@iynixil
Copy link
Owner

iynixil commented Apr 19, 2024

Steps to reproduce:

  1. Have at least 1 customer, 1 product and no orders initially. (0 orders)
  2. Enter multiple valid order commands.
  3. Enter valid command to add product to order.

Expected: Expected the orders created to be reflected in GUI

Actual: GUI shows a message to add a product to the orders

Rationale (includes explanation of severity):
If the app starts from a clean slate (step 1 of how to reproduce this problem), there are no orders initially. Then, when the user adds multiple orders without products in succession, they are only prompted on how to add a product to the orders. This is slightly misleading as it does not tell the user if the order has been created, and personally, I would assume that the order is created but not shown.
Then, the multiple orders created are not reflected on the GUI, which does not allow users to see how many existing orders there are.
If the user wants to add a product to any of the multiple orders, they cannot do so as the product will only be added to the latest order, and for previous orders created, while they actually do not exist, this is not shown to the user. While this way of order creation may not be the intended usage (hence Medium), it can be avoided and improved on.

Recommendation/Suggestion:
Reflect the orders in the GUI after an order
has been successfully created. Or, provide a command to show the number of existing orders and another command to show order details given the order index.
Or, state in documentation the combination of having to use order and product commands in succession to create an order, and if done otherwise, the order is not actually created.

@iynixil iynixil changed the title UI does not show immediately show the order created GUI does not show immediately show the order created Apr 19, 2024
@nus-pe-bot
Copy link

nus-pe-bot commented Apr 22, 2024

Team's Response

Duplicate with #3847

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Successfully adding order does not show any order appear

It is not clear when an order has been created already since it doesn't appear until after a product is added to it

This is a bit confusing for a new user.

Screenshot 2024-04-19 at 16.30.14.png


[original: nus-cs2103-AY2324S2/pe-interim#4854] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This is an intended feature as we believe that we should only show an order when it had products in it, as creating an order without products might be a mistake so we delay showing the order until the user has added a product to it, since orders are meant to exist in tandem with the products they contain. So rest assured the order is there, after adding a product, the user will promptly be able to view the order.

Items for the Tester to Verify

❓ Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

  • I disagree

Reason for disagreement: [replace this with your explanation]


❓ Issue severity

Team chose [severity.Low]
Originally [severity.Medium]

  • I disagree

Reason for disagreement: [replace this with your explanation]


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants