Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alignments with OpenID4VP Draft 22 #507

Merged
merged 24 commits into from
Jan 13, 2025
Merged

Alignments with OpenID4VP Draft 22 #507

merged 24 commits into from
Jan 13, 2025

Conversation

peppelinux
Copy link
Member

@peppelinux peppelinux commented Nov 25, 2024 •
edited
Loading

This PR:

In general, this PR has introduced the following breaking changes:

  • removed custom RP metadata parameterpresentation_definition_supported
  • renamed metadata type name wallet_relying_party to openid_credential_verifier
  • aligned JARM ref to the latest release
  • definitively removed deprecated client_id_scheme request parameter
  • additional clarifications about the importance of the parameter state in the presentation request
  • introduces dcql query, removed the dependency from presentation_definition
  • removed scopes in the rp requests
  • added client_id_schemes_supported in the wallet metadata during presentation
  • added client_id_schemes_supported in wallet attestation
  • typ value vc+sd-jwt renamed to dc+sd-jwt
  • when DCQL is used, vp_token is not an array but a json object
  • add further clarifications against the endpoint mixup attacks and using the endpoints attested within the federation trust chain metadata
  • fix the request-uri request including the wallet metadata using the application/x-www-form-urlencoded

peppelinux
peppelinux commented Nov 25, 2024
View reviewed changes
docs/en/remote-flow.rst Outdated Show resolved Hide resolved
peppelinux
peppelinux commented Nov 25, 2024
View reviewed changes
docs/en/remote-flow.rst Outdated Show resolved Hide resolved
@peppelinux peppelinux requested review from fmarino-ipzs, m-basili, giadas and grausof and removed request for fmarino-ipzs and m-basili November 25, 2024 14:47
@peppelinux peppelinux added this to the 0.9.0 milestone Nov 25, 2024
peppelinux
peppelinux commented Nov 27, 2024
View reviewed changes
docs/en/remote-flow.rst Outdated Show resolved Hide resolved
giadas
giadas reviewed Dec 23, 2024
View reviewed changes
docs/common/standards.rst Outdated Show resolved Hide resolved
giadas
giadas reviewed Dec 23, 2024
View reviewed changes
docs/en/remote-flow.rst Outdated Show resolved Hide resolved
giadas
giadas reviewed Dec 23, 2024
View reviewed changes
docs/en/remote-flow.rst Outdated Show resolved Hide resolved
giadas
giadas reviewed Dec 23, 2024
View reviewed changes
docs/en/remote-flow.rst Outdated Show resolved Hide resolved
giadas
giadas reviewed Dec 23, 2024
View reviewed changes
docs/en/remote-flow.rst Outdated Show resolved Hide resolved
@peppelinux peppelinux mentioned this pull request Jan 9, 2025
Open
@peppelinux
Copy link
Member Author

The current structure of the Remote Flow section is not easy to follow. For example, it starts with the details of the Request URI POST, even if in the flow this request occurs after the Authorization Request. To follow the order of the requests and responses presented in the flow, I suggest restructuring this section. Here a proposal

to facilitate the review of this PR, I have decided to move this into a separate issue: #519

peppelinux
peppelinux commented Jan 9, 2025
View reviewed changes
docs/en/remote-flow.rst Outdated Show resolved Hide resolved
peppelinux
peppelinux commented Jan 9, 2025
View reviewed changes
docs/en/remote-flow.rst Outdated Show resolved Hide resolved
@peppelinux peppelinux requested a review from giadas January 9, 2025 19:45
@peppelinux peppelinux mentioned this pull request Jan 9, 2025
Open
giadas
giadas reviewed Jan 10, 2025
View reviewed changes
docs/en/remote-flow.rst Outdated Show resolved Hide resolved
giadas
giadas reviewed Jan 10, 2025
View reviewed changes
docs/en/remote-flow.rst Outdated Show resolved Hide resolved
giadas
giadas reviewed Jan 10, 2025
View reviewed changes
docs/en/remote-flow.rst Outdated Show resolved Hide resolved
peppelinux and others added 2 commits January 10, 2025 11:11
peppelinux
peppelinux commented Jan 10, 2025
View reviewed changes
docs/en/remote-flow.rst Outdated Show resolved Hide resolved
@peppelinux peppelinux requested a review from giadas January 10, 2025 10:54
@peppelinux peppelinux merged commit cc9ac4e into versione-corrente Jan 13, 2025
8 of 9 checks passed
@peppelinux peppelinux mentioned this pull request Jan 15, 2025
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmarino-ipzs fmarino-ipzs fmarino-ipzs approved these changes

@giadas giadas giadas approved these changes

@grausof grausof grausof approved these changes

Assignees

@giadas giadas

Labels
presentation specification alignment
Projects
EUDI Wallet IT Technical Specifications
Status: Done
Milestone
0.9.0
4 participants
@peppelinux @giadas @grausof @fmarino-ipzs