-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: cannot docker-compose up anymore #1263
Comments
May be related to facebook/create-react-app#9077 (comment) |
Above solution with .dockerignore works for me |
@mfortini that's probably the right solution |
I had the same problem, the .dockerignore workaround didn't work for me. |
@ruphy sure |
Today i started "fresh" and I had to put bundle-install: bundle-setup
bundle config set path vendor/
bundle install
bundle-install-deployment: bundle-setup
bundle config set path vendor/
bundle install --deployment
test:
npm run lint
npm run test
scripts/pa11y.sh
bundle exec htmlproofer ./_site --assume-extension --check-html --allow-hash-href --empty-alt-ignore --only-4xx --disable-external
local:
bundle config set path vendor/
npx webpack-dev-server --config webpack.dev.js --color --progress -d --host 0.0.0.0 | bundle exec jekyll serve --livereload --incremental --host=0.0.0.0 --trace |
@zukka77 is that with current |
@bfabio no, it's here https://github.com/zukka77/developers.italia.it/blob/container-podman-friendly/Makefile it's part of this PR #1303 maybe I should have keep it separated 🤔 |
@zukka77 I meant: do you still have trouble building the site with current main? |
@bfabio with the one in the current main didn't work, I had to add |
This morning I came across the same issue and managed to fix it by adding I'm working on a fork made from the current master branch, with Docker Desktop v4.17.0 and Docker Compose v2.15.1 both installed on a Windows 10 machine. |
I'll lay some background info, because it's complicated™. There was a time when the build used to be quite inscrutable and we refactored it to remove a lot of complexity and randomness, yes this is the simplified version of it 😢 Judging purely by this experience if feel like it's a zero-sum game, where pulling the blanket from one side only uncovers the other, this because the Makefile and the build in general has to account for different environments and their subvariants:
There are a lot tweaks, some obvious and some less obvious but, in general they are time consuming and need to be tested on all those envs. That, in addition to having the preview on PRs as a way to bypass all the problems when it comes to small changes (which are the majority recently), has led to deprioritizing this issue. The root issue is having two different runtimes though. Jekyll served us well but I think the real solution is #1007 as the site got more dynamic, but of course it's way more work. For now, I believe we can try and do it step by step, putting We can split @zukka77's (thanks!) work zukka77@a5e1794 into three PRs:
I'd rather open a new issue for the removal of the unprivileged user, I'm not 100% sure about it because it would be a step back for Docker. |
The text was updated successfully, but these errors were encountered: