Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disabling autolink doesn't work #557

Closed
stbuehler opened this issue Jul 8, 2019 · 2 comments · Fixed by #995
Closed

disabling autolink doesn't work #557

stbuehler opened this issue Jul 8, 2019 · 2 comments · Fixed by #995
Labels
bug needs-contributor Someone needs to implement this. Help wanted! server (Python) server code
Milestone
0.13.1

Comments

@stbuehler
Copy link

Even after disabling autolink I get call kind of crap "linkified" (like ld.so to <a href="http://ld.so" rel="nofollow noopener">ld.so</a> or /usr/lib/x86_64-linux-gnu/libc/memcpy-preload.so to /usr/lib/x86_64-linux-gnu/libc/<a href="http://memcpy-preload.so" rel="nofollow noopener">memcpy-preload.so</a>).

Imho the Sanitizer shouldn't make new links, i.e. start set_links with if new: return None.

Opinions?
@ix5
Copy link
Member

ix5 commented Dec 31, 2021

Duplicate of #751

@ix5 ix5 marked this as a duplicate of #751 Dec 31, 2021
@ix5 ix5 closed this as completed Dec 31, 2021
@ix5 ix5 added the server (Python) server code label Dec 31, 2021
@ix5
Copy link
Member

ix5 commented Jan 5, 2022

On a second glance, this is a different issue entirely. Reopening.

@ix5 ix5 reopened this Jan 5, 2022
@ix5 ix5 added bug needs-contributor Someone needs to implement this. Help wanted! labels Jan 5, 2022
@ix5 ix5 added this to the 0.14 milestone Jun 4, 2022
pkvach added a commit to pkvach/isso that referenced this issue Mar 3, 2024
@pkvach
isso: html.py: Prevent auto creation of invalid links
7ef86f4 
Fixes isso-comments#557
@pkvach pkvach mentioned this issue Mar 3, 2024
Merged
3 tasks
jelmer pushed a commit that referenced this issue Mar 10, 2024
@pkvach
isso: html.py: Prevent auto creation of invalid links in comments (#995)
90aa041 
* isso: html.py: Prevent auto creation of invalid links

Fixes #557
@ix5 ix5 modified the milestones: 0.14, 0.13.1 May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug needs-contributor Someone needs to implement this. Help wanted! server (Python) server code
Projects
None yet
Milestone
0.13.1
Development

Successfully merging a pull request may close this issue.

isso: html.py: Prevent auto creation of invalid links in comments pkvach/isso
2 participants
@stbuehler @ix5