Skip to content
This repository has been archived by the owner on Feb 8, 2023. It is now read-only.

Improving multihash #455

Closed
DonaldTsang opened this issue May 22, 2017 · 5 comments
Closed

Improving multihash #455

DonaldTsang opened this issue May 22, 2017 · 5 comments

Comments

@DonaldTsang
Copy link

Apparently the codes in the Multihash test cases and the multihash specification do not match.

@DonaldTsang
Copy link
Author

The problem:
https://github.com/multiformats/go-multihash/blob/master/sum_test.go#L34
The first two bytes of Line 34 should be b240 while the first two bytes of Line 37 should be b260.
Links to adding Skein in the standard:
multiformats/multihash#83
multiformats/js-multihash#34
multiformats/go-multihash#52

@ghost
Copy link

ghost commented May 22, 2017

Thanks for noticing! Could you file an issue in multiformats/go-multihash instead, and close this one?

@DonaldTsang
Copy link
Author

@Igierth Issue already filed but no one noticed, so I brought it here.

@Kubuxu
Copy link
Member

Kubuxu commented May 24, 2017

@DonaldTsang you mean the hex string doesn't match?

This is due to varint encoding.

@daviddias
Copy link
Member

let's continue this convo on multiformats/multihash#83

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants