fix(toast): remove backdrop-no-scroll for last toast overlay #30123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case last overlay is a toast, the backdrop-no-scroll css class is removed from body. closes ionic-team#30112
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case last overlay is a toast, the backdrop-no-scroll css class is removed from body.
closes #30112
Issue number: resolves #
What is the current behavior?
In case the last overlay that will be dismissed is a toast the "backdrop-no-scroll" css class is not removed from body tag.
What is the new behavior?
With this fix, the "backdrop-no-scroll" class will be removed from body tag in case last overlay will be dismissed (for toasts as well).
Does this introduce a breaking change?
Other information
This PR is related to the following issue: #30112