Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple authentication from Web page #166

Closed
Romick2005 opened this issue Nov 19, 2020 · 3 comments
Closed

Apple authentication from Web page #166

Romick2005 opened this issue Nov 19, 2020 · 3 comments

Comments

@Romick2005
Copy link

Romick2005 commented Nov 19, 2020

Hi,
I am trying to implement apple authentication for my old iPhone 5S (max iOS version is 12.4.9).
I was trying to do it using react-apple-signin-auth module. But when importing it I got:
Unable to resolve module './AppleSigninButton.css' from eact-apple-signin-auth module.

How I can actually use react-apple-signin-auth in my react-native app? Any examples would help.

Also I was thinking if you have android login enable so why iOS < 13 could not have apple login via web page. Can you please elaborate on this what is the actual problem there and if you could please provide some links for more information that would be great!

The last question is how can I change apple sign in button text from "Sign in with Apple" to translated version fro example "Iniciar sesión con Apple" or some other text. Is there any restriction from apple? Just curious. Thank you!

By the way thank you for the nice library!

@mikehardy
Copy link
Collaborator

Hi there! Not sure about the import, that's going to be project-specific or perhaps a bug here but we'll need a reproduction based on the example

Great question about web login support for ios < 13, I think it's just historic at this point and lack of implementation. Specifically, Android was not supported until someone posted a PR for it, and web fallback for ios < 13 could be supported but it would also need someone from the community to post a PR as it's not a maintenance priority.

I am committed to doing whatever is necessary to help a contributor though - if you post up a PR for it I will work with you to get it merged, definitely

@mikehardy
Copy link
Collaborator

Happy to take PRs to resolve issues / extend functionality but as current maintainer the library currently handles my use cases, which means I do not have an interest in volunteering unpaid labor myself for use cases I don't need.

Happy to take those PRs and merge them though if anyone paying attention to this issue is motivated to develop them.

In the meantime closing this as stale

@mikehardy
Copy link
Collaborator

I rebased it and pushed the result to #335 - it needs testing, and I believe there are comments here that were not addressed

The way to move this forward is to test it, as mentioned on #335, and to look at any of my old comments here and resolve them

Would be cool to see it go in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants