Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performRequest hangs ios14 Simulator -> App Store Rejection (use ios13 or ios16 simulator) #141

Closed
se09deluca opened this issue Sep 22, 2020 · 50 comments
Labels
apple-issue bug Something isn't working

Comments

@se09deluca
Copy link

se09deluca commented Sep 22, 2020

[:point_down: SEE COMMENTS BELOW TO UNDERSTAND STATUS / GET YOUR APP APPROVED 👇]

Hi,
i've been experiencing this error from iOS 14.

I'm using @invertase/react-native-apple-authentication@1.1.2 as i don't need Apple Signin for Android.

Although, in past AppleStore reviewers rejects my app randomly, probably depending on who tests the app, this time there's no way to make it accepts.

const appleAuthRequestResponse = await appleAuth.performRequest({ requestedOperation: AppleAuthRequestOperation.LOGIN, requestedScopes: [AppleAuthRequestScope.EMAIL, AppleAuthRequestScope.FULL_NAME], });

It's a pity, this package works perfectly for real devices!
Could you suggest me, what to do? It's a problem experienced only in my case or not only?

My React Native info

System:
OS: macOS 10.15.6
CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
Memory: 671.25 MB / 16.00 GB
Shell: 5.7.1 - /bin/zsh
Binaries:
Node: 12.13.1 - /usr/local/bin/node
Yarn: 1.22.4 - /usr/local/bin/yarn
npm: 6.14.3 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 14.0, DriverKit 19.0, macOS 10.15, tvOS 14.0, watchOS 7.0
Android SDK:
API Levels: 23, 25, 26, 27, 28, 29
Build Tools: 28.0.3, 29.0.0, 29.0.2, 29.0.3
System Images: android-19 | Google APIs Intel x86 Atom, android-28 | Google APIs Intel x86 Atom, android-28 | Google Play Intel x86 Atom
IDEs:
Android Studio: 4.0 AI-193.6911.18.40.6626763
Xcode: 12.0/12A7209 - /usr/bin/xcodebuild
npmPackages:
react: 16.9.0 => 16.9.0
react-native: 0.61.5 => 0.61.5
npmGlobalPackages:
create-react-native-module: 0.16.0
react-native-cli: 2.0.1

@ferran9908

This comment has been minimized.

@mikehardy

This comment has been minimized.

@mikehardy

This comment has been minimized.

@rafaismyname

This comment has been minimized.

@gkothe

This comment has been minimized.

@dburdan

This comment has been minimized.

@ferran9908

This comment has been minimized.

@se09deluca se09deluca changed the title iOS 14 performRequest never return on Simulator -> AppleStore Rejection iOS 14 performRequest never returns on Simulator -> App Store Rejection Sep 23, 2020
@mikehardy
Copy link
Collaborator

mikehardy commented Sep 23, 2020

UPDATE - this works on iOS16 simulators (finally) so there is hope once Xcode 14 - which includes iOS16 simulator - is out of beta.. Until then:

There is no fix. I reproduce the problem.
For now assume the iOS14 simulator is broken.
The code works on iOS13 simulators. It works on iOS 13 and 14 real devices.

There is nothing we can do, I don't think except wait for a fix.

Simulators from iOS14.0 through iOS 15.x are all broken for sign in with apple.

Instruct app reviewers to use an iOS13 simulator or real device to test it until iOS16 comes out

@mikehardy mikehardy added apple-issue bug Something isn't working labels Sep 23, 2020
@anthlasserre

This comment has been minimized.

@mikehardy

This comment has been minimized.

@artmerlop

This comment has been minimized.

@artmerlop
Copy link

@mikehardy if you download iOS 13.6 simulator on Xcode > 12 you can test everything.

@se09deluca

This comment was marked as resolved.

@ihsanktmr

This comment has been minimized.

@mikehardy

This comment has been minimized.

@artmerlop
Copy link

I am having the same problem. The error i get is;

Error: The operation couldn’t be completed. (com.apple.AuthenticationServices.AuthorizationError error 1001.)

sign with apple on ios14 device works, ios14 simulator does not work. And app store keeps rejecting my app
Still no solution ?

@ihsanktmr you should download iOS 13.X simulator and test on that version, also when you send it to review specify that apple signin function will not work on iOS 14 simulator, because it's a bug from Apple, reported by many developers, I specified that and my app got aproved.

@MorelSerge

This comment has been minimized.

@mikehardy

This comment has been minimized.

@MorelSerge

This comment has been minimized.

@mikehardy
Copy link
Collaborator

mikehardy commented Oct 15, 2020

I'm going to close this as there is no action to take I don't think - it is an upstream bug out of our control

In app store review comments you should note for reviewers that if they test apple sign in, it is broken on ios14 simulators and they must use either a real device or ios13

@jaysoni9294-1

This comment has been minimized.

@KantaP

This comment has been minimized.

@mikehardy

This comment has been minimized.

@mikehardy

This comment was marked as resolved.

@mikehardy mikehardy reopened this Feb 24, 2021
@cylim

This comment was marked as resolved.

@mikehardy

This comment was marked as resolved.

@cylim

This comment was marked as resolved.

@mikehardy

This comment was marked as resolved.

@cylim

This comment was marked as resolved.

@mikehardy

This comment was marked as resolved.

@MariaFF

This comment was marked as resolved.

@htuzel
Copy link

htuzel commented May 20, 2021

You need to enable apple signin for your build (not only for debugging).
It was the issue for my case.
@MariaFF

@DKbyo
Copy link

DKbyo commented Jun 21, 2021

I had same issue, but I rewrote my code to use .then instead of await and found that my issue was caused because I didn't follow the Migration Guide since some constants were renamed. After follow the migration guide all was working again.

It seems that React Native + async is not handled correctly the errors and you cannot see what is happening.

@UsamaAshraf82

This comment was marked as resolved.

@mikehardy
Copy link
Collaborator

@UsamaAshraf82 it is working on a real device with iOS 14, I just re-tested it literally this moment to make sure before asserting it works on real device with iOS 14.

Not working on iOS14 simulator is a known issue with no workaround, out of control of this library

But if it is not working on a real device with iOS 14 for you, you should examine your project - I suspect something is not configured correctly for you and it is almost certainly project-specific

@StijnCoolen

This comment was marked as resolved.

@mikehardy

This comment was marked as resolved.

@StijnCoolen

This comment was marked as resolved.

@mikehardy
Copy link
Collaborator

mikehardy commented Dec 13, 2021

In my app store submission/testing instructions I say: "use a real device, or an ios13 simulator". I don't have problems, but then apple review is notoriously hit or miss by common knowledge and in my experience. It feels like each time they review they fail something that they passed before, despite no changes. I wish I was not so cynical in this area as it would be more helpful, but with apologies, that's where I'm at personally with them. It's a farce and I can't offer much help beyond what we know here technically by observation: ios14 and ios15 emulators do not appear to work with apple sign in 🤷

@renchap
Copy link

renchap commented Jun 24, 2022

According to a comment in the Apple dev forum, iOS 16 simulator fixes the issue.

If anybody running on the beta could confirm, it would be awesome news!

@mikehardy
Copy link
Collaborator

@renchap OH MY $DEITY! You are right! They fixed it. They finally fixed it. After only around 2 years. Wow.
Confirmed working on Xcode 14 beta 1 (beta2 is downloading for me still)

Note credential state "authorized" in screen cap. Note that if you have never signed in to your apple account on the simulator your first attempt will fail with error 1000 still, because the flow does not work well with the case where a user is never signed in to the device at all but that's okay because it does not happen in practice on real devices.

Second attempt works.

image

Xcode 14.0
Build version 14A5228q

@mikehardy
Copy link
Collaborator

(do note that they messed up the button styles though: different issue, what can we do!? #286 )

@mikehardy mikehardy changed the title performRequest hangs ios14 Simulator -> App Store Rejection (use ios13 simulator) performRequest hangs ios14 Simulator -> App Store Rejection (use ios13 or ios16 simulator) Jun 24, 2022
@aramvr
Copy link

aramvr commented Sep 16, 2023

I'm running on iOS 16.4 and still have the issue, I don't have the option to install the older iOS 13 version as it does not appear on the versions list.
I will appreciate if someone can share a solution.

@nelsonhernandeztrd
Copy link

I have a similar problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apple-issue bug Something isn't working
Projects
None yet
Development

No branches or pull requests