Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new search bar template on other pages #9236

Closed
RayBB opened this issue May 8, 2024 · 2 comments · Fixed by #9830
Closed

Use new search bar template on other pages #9236

RayBB opened this issue May 8, 2024 · 2 comments · Fixed by #9830
Assignees
@schu96
Labels
Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Module: Search Page(s) Issues pertaining to the Search page UI Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Design Issues related to UI design, branding, etc. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]

Comments

@RayBB
Copy link
Collaborator

RayBB commented May 8, 2024

After #9146 is merged

Followup from: #9086 (comment)

the Author page (https://openlibrary.org/authors/OL107911A/George_Bernard_Shaw)
the My Books Reading Log page (https://openlibrary.org/people/mekBot/books/want-to-read)
the Subject page (e.g. https://openlibrary.org/subjects/biology)

Describe the problem that you'd like solved

Proposal & Constraints

Additional context

Stakeholders
@RayBB RayBB added Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead State: Blocked Work has stopped, waiting for something (Info, Dependent fix, etc. See comments). [managed] labels May 8, 2024
@mekarpeles mekarpeles added Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Design Issues related to UI design, branding, etc. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Module: Search Page(s) Issues pertaining to the Search page UI and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels May 13, 2024
@schu96
Copy link
Contributor

schu96 commented Aug 28, 2024

Hi @RayBB I'd like to take on this issue, it looks like the subject page is the only one that needs updating from the list
image
image
image

@RayBB RayBB removed the State: Blocked Work has stopped, waiting for something (Info, Dependent fix, etc. See comments). [managed] label Aug 29, 2024
@RayBB
Copy link
Collaborator Author

RayBB commented Aug 29, 2024

@schu96 seems you're right. I've assigned you. Good luck!

@schu96 schu96 mentioned this issue Aug 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schu96 schu96

Labels
Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Module: Search Page(s) Issues pertaining to the Search page UI Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Design Issues related to UI design, branding, etc. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apply search bar template to subjects page schu96/openlibrary
3 participants
@RayBB @mekarpeles @schu96