Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uninitialized constant Carddav::AddressBookCollectionResource::ALL_PROPERTIES #15

Open
kristianm opened this issue Apr 3, 2014 · 1 comment

Comments

@kristianm
Copy link
Contributor

I noticed that the newly added AddessBookCollectionResource added in 8c67d87 didn't define some constants as the other resources do. I added this to my fork

# /app/models/carddav/address_book_collection_resource.rb

  ALL_PROPERTIES =  {}
  EXPLICIT_PROPERTIES = {}

but didn't add this into pull request since I couldn't foresee the consequences.

@inferiorhumanorgans
Copy link
Owner

If it works for you and passes the specs, I'd be happy to merge it. Travis is currently setup to only test w/ Ruby 1.9.3, but should probably be setup to test w/ 2.0 and 2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants