Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check buildPrepareG2 #14

Open
paberr opened this issue Mar 18, 2020 · 0 comments
Open

Check buildPrepareG2 #14

paberr opened this issue Mar 18, 2020 · 0 comments

Comments

@paberr
Copy link

paberr commented Mar 18, 2020

Hi,

I am not familiar with your code base, but when comparing the buildPrepareG2 with other pairing implementations, I found a difference in the following line:
https://github.com/iden3/websnark/blob/3dd30d54991610d1194cd78e140c4cd89edd3132/src/mnt6753/build_mnt6753.js#L438

Zexe's implementation that I am working with right now computes:
let minus_r_affine_x = r.x * &rz2_inv;
whereas your code multiplies by rz_inv.

I haven't checked all the code that is following, so perhaps your prepAddStep expects this as an input. However, I still wanted to bring up the difference for you to check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant