Error deriving from PorousFlowMasstimederivative

[navier-rgb]

Hello,
It looks impossible to derive from PorousFlowMasstimederivative without re-declaring (in the header file) and redefining each property as [_qp] instead of [_i]. Why is that? Is there a way around it? I want to inherit without redefining all properties. I got the following error after running my derived object.

*** ERROR ***
The following error occurred in the object "MOOSE Problem", of type "FEProblem".

Material property 'PorousFlow_porosity_nodal', requested by 'mass_a' is not defined on block 0
Material property 'dPorousFlow_porosity_nodal_dvar', requested by 'mass_a' is not defined on block 0
Material property 'dPorousFlow_porosity_nodal_dgradvar', requested by 'mass_a' is not defined on block 0
Material property 'PorousFlow_fluid_phase_density_nodal', requested by 'mass_a' is not defined on block 0
Material property 'dPorousFlow_fluid_phase_density_nodal_dvar', requested by 'mass_a' is not defined on block 0
Material property 'PorousFlow_saturation_nodal', requested by 'mass_a' is not defined on block 0
Material property 'dPorousFlow_saturation_nodal_dvar', requested by 'mass_a' is not defined on block 0
Material property 'PorousFlow_mass_frac_nodal', requested by 'mass_a' is not defined on block 0
Material property 'dPorousFlow_mass_frac_nodal_dvar', requested by 'mass_a' is not defined on block 0
Material property 'PorousFlow_primary_sps_conc_nodal', requested by 'mass_a' is not defined on block 0
Material property 'dPorousFlow_primary_sps_conc_nodal_dvar', requested by 'mass_a' is not defined on block 0
Material property 'PorousFlow_porosity_nodal', requested by 'mass_b' is not defined on block 0
Material property 'dPorousFlow_porosity_nodal_dvar', requested by 'mass_b' is not defined on block 0
Material property 'dPorousFlow_porosity_nodal_dgradvar', requested by 'mass_b' is not defined on block 0
Material property 'PorousFlow_fluid_phase_density_nodal', requested by 'mass_b' is not defined on block 0
Material property 'dPorousFlow_fluid_phase_density_nodal_dvar', requested by 'mass_b' is not defined on block 0
Material property 'PorousFlow_saturation_nodal', requested by 'mass_b' is not defined on block 0
Material property 'dPorousFlow_saturation_nodal_dvar', requested by 'mass_b' is not defined on block 0
Material property 'PorousFlow_mass_frac_nodal', requested by 'mass_b' is not defined on block 0
Material property 'dPorousFlow_mass_frac_nodal_dvar', requested by 'mass_b' is not defined on block 0
Material property 'PorousFlow_primary_sps_conc_nodal', requested by 'mass_b' is not defined on block 0
Material property 'dPorousFlow_primary_sps_conc_nodal_dvar', requested by 'mass_b' is not defined on block 0

#include "APMassTimeDerivative.h"

#include "MooseVariable.h"

#include "libmesh/quadrature.h"

#include <limits>

registerMooseObject("APApp", APMassTimeDerivative);

InputParameters
APMassTimeDerivative::validParams()
{
  InputParameters params = PorousFlowMassTimeDerivative::validParams();
  params.addRequiredParam<std::vector<Real>>(
      "ap_mass",
      "molar_mass (kg/mol) of each fluid component");
  params.addClassDescription("Derivative of fluid-component mass with respect to time.  Mass "
                             "lumping to the nodes is used.");
  return params;
}

APMassTimeDerivative::APMassTimeDerivative(const InputParameters & parameters)
  : PorousFlowMassTimeDerivative(parameters),
    _ap_mass(getParam<std::vector<Real>>("ap_mass")),
    _ap(getMaterialProperty<std::vector<std::vector<Real>>>("PorousFlow_ap_nodal")),
    _ap_old(
        getMaterialPropertyOld<std::vector<std::vector<Real>>>("PorousFlow_ap_nodal")),
    _dap_dvar(getMaterialProperty<std::vector<std::vector<std::vector<Real>>>>(
        "dPorousFlow_ap_nodal_dvar"))
{
    // PorousFlowMassTimeDerivative already made the necessary checks!
}

Real
APMassTimeDerivative::computeQpResidual()
{
  Real mass = 0.0;
  Real mass_old = 0.0;
  for (unsigned ph = 0; ph < _num_phases; ++ph)
  {
    const Real dens = (_multiply_by_density ? (*_fluid_density)[_i][ph] : 1.0);
    mass += dens * _fluid_saturation_nodal[_i][ph] * _ap[_i][ph][_fluid_component];
    const Real dens_old = (_multiply_by_density ? (*_fluid_density_old)[_i][ph] : 1.0);
    mass_old +=
        dens_old * _fluid_saturation_nodal_old[_i][ph] * _ap_old[_i][ph][_fluid_component];
  }
  const Real strain = (_has_total_strain ? (*_total_strain_old)[_qp].trace() : 0.0);

  return _test[_i][_qp] * (1.0 + strain) * (_porosity[_i] * mass - _porosity_old[_i] * mass_old) /
         _dt;
}

Real
APMassTimeDerivative::computeQpJacobian()
{
  // If the variable is not a PorousFlow variable (very unusual), the diag Jacobian terms are 0
  if (!_var_is_porflow_var)
    return 0.0;
  return computeQpJac(_dictator.porousFlowVariableNum(_var.number()));
}

Real
APMassTimeDerivative::computeQpOffDiagJacobian(unsigned int jvar)
{
  // If the variable is not a PorousFlow variable, the OffDiag Jacobian terms are 0
  if (_dictator.notPorousFlowVariable(jvar))
    return 0.0;
  return computeQpJac(_dictator.porousFlowVariableNum(jvar));
}

Real
APMassTimeDerivative::computeQpJac(unsigned int pvar)
{
  const unsigned nearest_qp = (_strain_at_nearest_qp ? (*_nearest_qp)[_i] : _i);

  const Real strain = (_has_total_strain ? (*_total_strain_old)[_qp].trace() : 0.0);

  // porosity is dependent on variables that are lumped to the nodes,
  // but it can depend on the gradient
  // of variables, which are NOT lumped to the nodes, hence:
  Real dmass = 0.0;
  for (unsigned ph = 0; ph < _num_phases; ++ph)
  {
    const Real dens = (_multiply_by_density ? (*_fluid_density)[_i][ph] : 1.0);
    dmass += dens * _fluid_saturation_nodal[_i][ph] * _ap[_i][ph][_fluid_component] *
             _dporosity_dgradvar[_i][pvar] * _grad_phi[_j][nearest_qp];
  }

  if (_i != _j)
    return _test[_i][_qp] * (1.0 + strain) * dmass / _dt;

  // As the fluid mass is lumped to the nodes, only non-zero terms are for _i==_j
  for (unsigned ph = 0; ph < _num_phases; ++ph)
  {
    if (_multiply_by_density)
      dmass += (*_dfluid_density_dvar)[_i][ph][pvar] * _fluid_saturation_nodal[_i][ph] *
               _ap[_i][ph][_fluid_component] * _porosity[_i];
    const Real dens = (_multiply_by_density ? (*_fluid_density)[_i][ph] : 1.0);
    dmass += dens * _dfluid_saturation_nodal_dvar[_i][ph][pvar] *
             _ap[_i][ph][_fluid_component] * _porosity[_i];
    dmass += dens * _fluid_saturation_nodal[_i][ph] *
             _dap_dvar[_i][ph][_fluid_component][pvar] * _porosity[_i];
    dmass += dens * _fluid_saturation_nodal[_i][ph] * _ap[_i][ph][_fluid_component] *
             _dporosity_dvar[_i][pvar];
  }
  return _test[_i][_qp] * (1.0 + strain) * dmass / _dt;
}

[cpgr]

The error means that a nodal version of those material properties isn't supplied. We use an action (PorousFlowAddMaterialAction) to add either nodal or qp versions of each material (or both if required), depending on what kernels are added. As you have inherited from PorousFlowMassTimeDerivative, your kernel is looking for nodal versions, but the action doesn't know what to add for your new kernel, so only defaults to qp versions.

You can just specify at_nodes = true in the input file for all of those materials that provide the properties that are missing in the error message (you might need to have two versions, one with at_nodes = true and one without, depending on your other kernels, see https://github.com/idaholab/moose/blob/next/modules/porous_flow/test/tests/actions/addmaterials.i for an example).