Skip to content

Latest commit

 

History

History
29 lines (20 loc) · 1.27 KB

README.md

File metadata and controls

29 lines (20 loc) · 1.27 KB

CodeReviewClub

A code review happens when a group of people get together to talk about a piece of code.

Next meeting: Friday, 9th of June, 13:30, CAUP's meeting room

broadcast link: https://appear.in/ia-codereviewclub

steps and duties

  • if you are presenting your code in the CRC (do this at least 24h before the meeting)

    • clone this repository (git clone https://github.com/iastro-pt/CodeReviewClub.git)
    • create a new branch called "CR#", with its own number ([cd CodeReviewClub] and git checkout -b CR324) [check the current number with git branch]
    • add your code and commit (git add script_name.py and git commit -m "CR324: add script for review) no need to clean the code beforehand, that's one of the goals of the CRC!
    • push (git push origin CR324)
    • on the github site (here), create a pull request
    • feel happy

  • if you are the meeting's "secretary"

    • In the pull request page, here on github, start a code review
    • Write the comments and suggestions discussed during the meeting

  • if you are attending the meeting

    • in the 24h before the meeting, feel free to go through the pull request the presenter created
    • during the CRC, discuss the code and help the presenter make changes / solve problems / improve the code