Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[suggestion]: remove samples from iroha_client public API #4271

Closed
0x009922 opened this issue Feb 8, 2024 · 1 comment · Fixed by #5124
Closed

[suggestion]: remove samples from iroha_client public API #4271

0x009922 opened this issue Feb 8, 2024 · 1 comment · Fixed by #5124
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@0x009922
Copy link
Contributor

0x009922 commented Feb 8, 2024 

          this needs to be removed from the public API of a client. We can open a ticket

Originally posted by @mversic in #4239 (comment)
@0x009922 0x009922 added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Feb 8, 2024
@0x009922
Copy link
Contributor Author

0x009922 commented Feb 8, 2024

Also related, because it also exports samples for tests: #4136

@0x009922 0x009922 mentioned this issue Feb 8, 2024
Merged
@mversic mversic mentioned this issue Jul 31, 2024
Closed
@nxsaken nxsaken added this to Iroha Sep 4, 2024
@nxsaken nxsaken moved this to Backlog in Iroha Sep 4, 2024
@0x009922 0x009922 linked a pull request Oct 11, 2024 that will close this issue
refactor!: black-box integration tests #5124
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor!: black-box integration tests 0x009922/iroha
2 participants
@nxsaken @0x009922