Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] Replace FindAccountsWithPermissionTokenDefinition with filtered FindAllAccounts #3720

Closed
Arjentix opened this issue Jul 18, 2023 · 2 comments
Closed

[refactor] Replace FindAccountsWithPermissionTokenDefinition with filtered FindAllAccounts #3720

Arjentix opened this issue Jul 18, 2023 · 2 comments
Assignees
@DCNick3
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality

Comments

@Arjentix
Copy link
Contributor

Should be done after the merge of #3707 as a part of #3671 or in a separate PR.

Who can help?

@appetrosyan , @DCNick3
@Arjentix Arjentix added iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality labels Jul 18, 2023
@Arjentix Arjentix mentioned this issue Jul 18, 2023
Merged
5 tasks
@mversic
Copy link
Contributor

mversic commented Jul 18, 2023

while we're at it, we should remove FindAccountsByName and FindAssetsByName(FindAssetsByName)

@mversic mversic mentioned this issue Jul 8, 2024
Closed
5 tasks
@mversic mversic self-assigned this Jul 8, 2024
@mversic mversic closed this as completed Jul 9, 2024
@mversic mversic reopened this Jul 9, 2024
@mversic mversic assigned DCNick3 and unassigned mversic Jul 9, 2024
@DCNick3 DCNick3 mentioned this issue Jul 10, 2024
Merged
6 tasks
@DCNick3
Copy link
Contributor

DCNick3 commented Aug 26, 2024

I believe this is done as of the merge #4833

@DCNick3 DCNick3 closed this as completed Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DCNick3 DCNick3

Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor!: remove FindAssetsByName query mversic/iroha
3 participants
@DCNick3 @Arjentix @mversic