Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggest publish v1.01 to npm. breaking bug in HTTP to path /Hubot/help #42

Closed
changhaitravis opened this issue Nov 17, 2017 · 8 comments

Comments

@changhaitravis
Copy link

Please publish version 1 to npm

There's a bug in version 0.2.2 which is what is currently in npm right now, when trying to access the help page via http. i.e., http://localhost:8080/Hubot/help when running bin/hubot

ReferenceError: renamedHelpCommands is not defined at C:\workspace\hubot\node_modules\hubot-help\src\help.coffee:83:14

I've confirmed this bug was not present in version 0.2.0.

@changhaitravis changhaitravis changed the title suggest publish v1.01 to npm suggest publish v1.01 to npm. breaking bug in HTTP to path /Hubot/help Nov 17, 2017
@bartfeenstra
Copy link
Contributor

Please do publish newer versions to npm. We were using 0.2.2. accidentally for a while, because that was the latest publicly available release on npmjs.org.

@changhaitravis So I just installed v1, and it's got the same bug.

@bartfeenstra
Copy link
Contributor

#43 should fix this error.

@changhaitravis
Copy link
Author

I didn't test v1 lol, I just eyed the line of code where it broke and checked in v1 to see if the same line was present. I'm rather surprised it didn't get fixed.

@mose
Copy link
Member

mose commented Jan 28, 2018

The fix is merged, but I can't do releases. Gotta nag the release powers to get it done. Thanks guys! :)

@bartfeenstra
Copy link
Contributor

Thanks for keeping us updated :)

To anyone who can do releases: note that #44 fixes what looks like a critical bug and, at the time of writing this comment, has not been merged yet.

@ParthKolekar
Copy link

const fun = await hubotHelpRelease();

My fun is awaiting a hubotHelpRelease. 😇

Can someone please help?

@Vicleslie
Copy link

Hi this issues is still not fixed in the npm latest version (1.0.1). I installed the latest hubot-help version from npm and the code seems still to be the old one?

@msudol
Copy link

msudol commented Nov 9, 2021

Decided to publish a new package to replace hubot-help with a bunch of fixes and feature improvements, if you are still using hubot, give hubot-help-plus a try. https://www.npmjs.com/package/hubot-help-plus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants