New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try to improve the situation about HUBOT_HELP_REPLY_IN_PRIVATE #31

Closed

mose wants to merge 2 commits into master from reply_private

Member

mose commented Jun 3, 2017

This patch addresses various issues:

fixes HUBOT_HELP_REPLY_IN_PRIVATE still replying publicly #21 and add support for user.id being used instead of user.name for sending help message in private #15
fixes Don't DM "replied to you in private!" when help is being queried via DM #16 for irc adapter, but slack still has that issue (not sure there is a way to fix that for slack as it is)

mose added 2 commits

June 4, 2017 06:23


          try to improve the situation about HUBOT_HELP_REPLY_IN_PRIVATE

c7c2ddb


          tested with rocketchat, it fails

49a6f88

Member Author

mose commented Jul 2, 2017

Obsolete PR because it's all js now.

mose closed this

gr2m deleted the reply_private branch

July 2, 2017 17:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet