Don't DM "replied to you in private!" when help is being queried via DM #16
Labels
Comments
|
The problem is that it's very difficult for Hubot to differentiate between a private message and a public one. It might be worth coming up with a PR against Hubot itself to let adapters specify direct messages. |
|
couldn't we treat the room check the same way we handle it when we're sending the message? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Hi, |
|
hubotio/hubot#1098 is an upstream issue around documenting the concept of private messages. |
MLCarey321
added a commit
to MLCarey321/hubot-help
that referenced
this issue
Jul 13, 2017
MLCarey321
added a commit
to MLCarey321/hubot-help
that referenced
this issue
Jul 13, 2017
If the room from which the message was sent is a DM with the user, do not include the "replied to you in private!" message.
|
🎉 This issue has been resolved in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When
HUBOT_HELP_REPLY_IN_PRIVATEis set, and a user requests help of the bot while in a group/channel, the bot replies in the same channel "replied to you in private!". However, when you ask the bot for help in a DM, the bot still says "replied to you in private!" in the DM before it sends the help response (also in a DM).The text was updated successfully, but these errors were encountered: