🚨 fix for "_table_exists?" method

[guyanbiao]

Hi huacnlee, Thanks for your gem, it's quite handy, But there is a potential issue here.

In the code here https://github.com/huacnlee/rails-settings-cached/blob/main/lib/rails-settings/base.rb#L157
the method will rescue all the errors.

It would be very bad if the application can't read the correct settings either because of timeout or something else and then get the default value instead, since these settings could be used to control the business flow, the default value could be very different from the production one.

I suggest just rescue specific errors such as "DB not exist" to let it go through the migration step and expose other errors to the application.

[huacnlee]

Do you used Setting.key in migrations?

[guyanbiao]

nope

[guyanbiao]

My point is better to raise exceptions instead of return a default value silently if can't read settings from the database.

[monachi]

we have to override this, to let it raise exceptions, instead of falling back to default values

    def _table_exists?
      table_exists?
    end