Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise law of demeter rule #89

Open
LinqLover opened this issue Jan 9, 2025 · 0 comments
Open

Revise law of demeter rule #89

LinqLover opened this issue Jan 9, 2025 · 0 comments

Comments

@LinqLover
Copy link
Contributor

The current rule appears to be undercomplex with regard to allowed domains. Discuss whether the logic of the rule needs to be changed or the excluded selector list needs to extended only.

Example false positive:

checkPlantCollision: aPlant
    (self right > aPlant left and: [self left < aPlant right]) ifTrue: [
        self
            noSpeed;
            eat: aPlant;
            collided: true]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant