Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary size check missing some cases #42

Open
lars-seifert opened this issue May 31, 2018 · 0 comments
Open

Unnecessary size check missing some cases #42

lars-seifert opened this issue May 31, 2018 · 0 comments

Comments

@lars-seifert
Copy link
Contributor

Description says: "Check for code that checks that a collection is non-empty before sending it an iteration message (e.g., do:, collect:, etc.). Since the collection iteration messages work for empty collections, we do not need to clutter up our method with the extra size check.".
But it does not find "collection isEmpty not ifFalse: [collection do: [:each | ...]]"
Enhance it. Test is existing, maybe enhance it further!?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant