Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditionally Hide Routes in Sidebar #21

Closed
vcolmenar opened this issue Feb 12, 2023 · 1 comment · May be fixed by #22
Closed

Conditionally Hide Routes in Sidebar #21

vcolmenar opened this issue Feb 12, 2023 · 1 comment · May be fixed by #22

Comments

@vcolmenar
Copy link

vcolmenar commented Feb 12, 2023 •
edited
Loading

User Story
As a developer,
I want to have a hidden prop in routes.js
So that I can create routes respected by react-router, but not shown in Sidebar.js

Description
A hidden prop can be added in routes.js that would still be loaded into the react-router, but not rendered in the Sidenav.
This will allow devs to not have to manually create custom router logic for their nested routes.

See PR:
https://github.com/horizon-ui/horizon-ui-chakra/pull/22/files?diff=split&w=1 (whitespace removed for readability)
@vcolmenar vcolmenar mentioned this issue Feb 12, 2023
Open
@simmmpleweb
Copy link
Contributor

Hello, @vcolmenar ! Thanks for supporting Horizon! For the moment, I will not merge, however, in future Horizon 2.0 we might add this ass a new feature,
Regards, Vlad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Conditionally Hide Routes in Sidebar vcolmenar/horizon-ui-chakra
2 participants
@vcolmenar @simmmpleweb