-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close syntax missing in Hreflang Tag #1144
Comments
@RajMankotia As far as I know it doesn't matter if tags are self-closing when they've been processed by the DOM and otherwise the browser itself would take care of that. What is the impact you see? |
I will address this issue today, thanks Raj |
or we can try and check if it resolves this then it's fine. |
Adding this self-closing tags manually is not an option, since even if we do, the browser will remove them. This happens according to https://developer.mozilla.org/en-US/docs/Glossary/Void_element I checked the old website in https://live-md30.pantheonsite.io/ and I also dont see any self-closing tags |
It's from old website - and it's that we implemented on migratedat the end .com/" /> I don't know more about coding but everywhere I see this tag applied or suggested on web they have closed it with a forward slash ( / ) at the end, but in our case, it's not. |
@RajMankotia what is the tool you use to check which complains? Also, please double check on the old site: if you do view source yes there is a Additionally you can test the following lines in any browser console:
You will see the link tag has no |
Hi @mhaack |
From what I see in the original site the links were already present in the html, could the issue be that we're adding them with javascript? |
There is a chance that different syntax is used in JavaScript for the hreflang tag. It is like the old HTML that we used. |
Yes that is the case, as these check tools don't execute JS |
@mhaack @RajMankotia effectively when I do a curl GET request on the site page, the response does not contain any hreflang tags This could be the issue since the tool GETs the page, doesnt see the tags and reports the error |
@jose-correia yes they are added client side |
@jose-correia got it but eventually it should get verified by Semrush as this is the same tool used and suggested by business. @mhaack as discussed in last call can we add it via meta tag? |
Hi @lydiapuric,
Please check the hreflang tag for all where we implemented we did not close the tag with "/>"
in old we have like this-
-- | | | | | |This we have now-
Please fix this.
The text was updated successfully, but these errors were encountered: