New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No need to use forward method? #11

Open

nkkbr opened this issue Jun 18, 2024 · 0 comments

nkkbr commented Jun 18, 2024

pytorch-llama/model.py

Lines 230 to 235 in 067f8a3

    
           # (B, Seq_Len, Dim) + (B, Seq_Len, Dim) --> (B, Seq_Len, Dim) 
        
           h = x + self.attention.forward( 
        
               self.attention_norm(x), start_pos, freqs_complex 
        
           ) 
        
           # (B, Seq_Len, Dim) + (B, Seq_Len, Dim) --> (B, Seq_Len, Dim) 
        
           out = h + self.feed_forward.forward(self.ffn_norm(h))

No need to use forward method?
I mean, we could use nn.Module directly.

h = x + self.attention(self.attention_norm(x), start_pos, freqs_complex)
out = h + self.feed_forward(self.ffn_norm(h))

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment