Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Declarative configuration #43

Closed
wants to merge 12 commits into from
Closed

[WIP] Declarative configuration #43

wants to merge 12 commits into from

Conversation

AndreyErmilov
Copy link
Contributor

Close #36

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2021 •
edited by codecov bot
Loading

Codecov Report

Merging #43 (5a9e741) into master (c3eea33) will increase coverage by 3.41%.
The diff coverage is n/a.

❗ Current head 5a9e741 differs from pull request most recent head 1cfccd0. Consider uploading reports for the commit 1cfccd0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
+ Coverage   71.00%   74.42%   +3.41%     
==========================================
  Files          41       41              
  Lines         714      696      -18     
==========================================
+ Hits          507      518      +11     
+ Misses        207      178      -29
Impacted Files Coverage Δ
hitbox-actix/src/actor.rs 80.00% <0.00%> (-10.00%) ⬇️
hitbox/src/value.rs 60.00% <0.00%> (-3.34%) ⬇️
hitbox-actix/src/messages.rs 88.88% <0.00%> (-2.03%) ⬇️
hitbox/src/states/upstream_polled/successful.rs 40.74% <0.00%> (-0.93%) ⬇️
hitbox-derive/src/macro_attributes.rs 0.00% <0.00%> (ø)
hitbox/src/states/cache_polled/error.rs 0.00% <0.00%> (ø)
hitbox/src/states/cache_polled/actual.rs 100.00% <0.00%> (ø)
hitbox/src/states/cache_policy/non_cacheable.rs 100.00% <0.00%> (ø)
hitbox/src/states/cache_policy/cacheable.rs 90.90% <0.00%> (+0.90%) ⬆️
hitbox/src/states/initial/base.rs 75.55% <0.00%> (+1.13%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3eea33...1cfccd0. Read the comment docs.

@singulared
Copy link
Member

Moved to hitboxd repository.

@singulared singulared closed this Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Declarative configuration
3 participants
@AndreyErmilov @codecov-commenter @singulared