New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

divide-by-zero for real DES5YR data #17

Open

RickKessler opened this issue Jul 2, 2024 · 1 comment

Collaborator

RickKessler commented Jul 2, 2024

while testing scone, I noticed divide-by-zero warnings for real DES-SN5YR data, but not for sims.

Collaborator Author

RickKessler commented Jul 3, 2024

divide by zero is from these two lines of code in base.py:

    sn_lcdata.add_row([min(sn_lcdata['mjd'])-100, 0, 0, expected_filters[2]])
    sn_lcdata.add_row([max(sn_lcdata['mjd'])+100, 0, 0, expected_filters[2]])

Fix is to replace second zero (flux_err) with 0.1

This was referenced Jul 3, 2024

minor bug fix to avoid divide-by-zero warnings #18

Closed

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment